Make the message clearer to avoid confusion about a scary and lengthy test stack #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test stack
Summary:
We have a pretty convenient feature in Ax' `TestCase`, to deeply compare unequal objects. This can help a lot if you know how to use it, but folks mentioned to me that because the printout is lengthy, folks sometimes get scared of it and don't read it all the way through. Here's my attempt to make it friendlier : )
For illustration, printout (see how it's actually pretty useful if we look all the way through?):
{F1974874829}
Created from CodeHub with https://fburl.com/edit-in-codehub
Reviewed By: Cesar-Cardoso
Differential Revision: D68987651
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68987651 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3298 +/- ##
=======================================
Coverage 96.04% 96.04%
=======================================
Files 518 518
Lines 52162 52162
=======================================
Hits 50098 50098
Misses 2064 2064 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 6ae638c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have a pretty convenient feature in Ax'
TestCase, to deeply compare unequal objects. This can help a lot if you know how to use it, but folks mentioned to me that because the printout is lengthy, folks sometimes get scared of it and don't read it all the way through. Here's my attempt to make it friendlier : )For illustration, printout (see how it's actually pretty useful if we look all the way through?):
{F1974874829}
Created from CodeHub with https://fburl.com/edit-in-codehub
Reviewed By: Cesar-Cardoso
Differential Revision: D68987651